Topic refactor #3483
Merged
Topic refactor #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
requested changes
Jul 26, 2024
There was a problem hiding this comment.
Requesting changes to have broadcast da also accept a topic. Also given the calls to the network are already split, do we even need to pass a topic in as an argument to the connected network? Either way broadcast_message and broadcast_da_message should have the same signature, or be combined again
Comment on lines
274
to
279
| async fn broadcast_message( | ||
| &self, | ||
| message: Vec<u8>, | ||
| recipients: BTreeSet<K>, | ||
| topic: Topic, | ||
| broadcast_delay: BroadcastDelay, | ||
| ) -> Result<(), NetworkError>; |
There was a problem hiding this comment.
Why did broadcast DA not also change?
There was a problem hiding this comment.
DA broadcast is a direct send to all recipients instead of an actual broadcast
There was a problem hiding this comment.
I think we should remove da_broadcast_message and conditionally on the topic have the DA specific logic when needed (as in Libp2p)
bfish713
approved these changes
Jul 26, 2024
lukaszrzasik
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3485
This PR:
Refactors all networks to broadcast messages through
Topicsinstead of a static list of all recipients. This will be needed to support users dynamically leaving and joining the networkThis PR does not:
Make any breaking protocol changes
Key places to review:
libp2p_network.rs,memory_network.rs